Skip to content
Snippets Groups Projects

Move the content of swh/objstorage/__init__.py in swh/objstorage/factory.py

Closed Move the content of swh/objstorage/__init__.py in swh/objstorage/factory.py
generated-differential-D3062-source into generated-differential-D3062-target
2 unresolved threads
Closed David Douard requested to merge generated-differential-D3062-source into generated-differential-D3062-target
2 unresolved threads

This is needed to "empty" the swh.objstorage's module from any non-subpackage objects, so we can implement the swh.objstorage.replayer outside the swh.objstorage's repo, in a dedicated repo/project.

Migrated from D3062 (view on Phabricator)

Merge request reports

Approval is optional

Closed by Phabricator Migration userPhabricator Migration user 4 years ago (Apr 27, 2020 1:19pm UTC)

Merge details

  • The changes were not merged into master.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
swh/objstorage/__init__.py
3 3 # License: GNU General Public License version 3, or any later version
4 4 # See top-level LICENSE file for more information
5 5
6 from swh.objstorage.objstorage import ObjStorage, ID_HASH_LENGTH # noqa
7 from swh.objstorage.backends.pathslicing import PathSlicingObjStorage
8 from swh.objstorage.backends.in_memory import InMemoryObjStorage
9 from swh.objstorage.api.client import RemoteObjStorage
10 from swh.objstorage.multiplexer import MultiplexerObjStorage, StripingObjStorage
11 from swh.objstorage.multiplexer.filter import add_filters
12 from swh.objstorage.backends.seaweed import WeedObjStorage
13 from swh.objstorage.backends.generator import RandomGeneratorObjStorage
6 from typing import Iterable
7 from pkgutil import extend_path
14 8
15 from typing import Callable, Dict, Union
9 __path__: Iterable[str] = extend_path(__path__, __name__)
  • Antoine R. Dumont
    Antoine R. Dumont @ardumont started a thread on the diff
    • swh/objstorage/tests/test_multiplexer_filter.py
    1 # Copyright (C) 2015-2018 The Software Heritage developers
    1 # Copyright (C) 2015-2020 The Software Heritage developers
  • Antoine R. Dumont mentioned in merge request !67 (closed)

    mentioned in merge request !67 (closed)

  • Antoine R. Dumont
    Antoine R. Dumont @ardumont ·
    Maintainer

    ok, some comments in the diff.

  • Antoine R. Dumont
    Antoine R. Dumont @ardumont ·
    Maintainer

    Merge request was accepted

  • Antoine R. Dumont approved this merge request

    approved this merge request

  • David Douard
    David Douard @douardda ·
    Author Maintainer

    update copyright dates of modifed files + fix a typo

  • Software Heritage Continuous Integration for public repositories
    Software Heritage Continuous Integration for public repositories @swh-public-ci ·

    Build is green

    Patch application report for D3062 (id=10912)

    Rebasing onto 17f81a70...

    Current branch diff-target is up to date.
    Changes applied before test
    commit bd2b5e651aedf25feefa4b7970e80f620afd2b6b
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Apr 24 15:39:35 2020 +0200

    Move the content of swh/objstorage/__init__.py in swh/objstorage/factory.py
    
    This is needed to "empty" the swh.objstorage's *module* from any
    non-subpackage objects, so we can implement the swh.objstorage.replayer
    outside the swh.objstorage's repo, in a dedicated repo/project.

    See https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/5/ for more details.

  • David Douard
    David Douard @douardda ·
    Author Maintainer

    Merge request was merged

  • David Douard closed

    closed

    • Please register or sign in to reply