Delete operation in objstorage
Closed
requested to merge generated-differential-D240-source into generated-differential-D240-target
Migrated from D240 (view on Phabricator)
Merge request reports
Activity
Filter activity
This looks generally good to me.
I've only a couple of nits that I'd like to see fixed before accepting this:
- the test for checking that deletion is not allowed when allow_delete is //explicitly// set to False is good. But I'd like to have an additional test, showing that //by default// deletions are not allowed. By the look of it I suspect that might need instantiating a dedicated object storage for that test, but that's a good idea anyhow
- when stumbling on the code, it might be obscure why the delete methods are calling super() why others are not. It's worth adding comments there explaining that it is so because the parent class is responsible of checking for delete permission
(@olasd has already approved this, but it was still waiting for me)
Please register or sign in to reply