Skip to content
Snippets Groups Projects

Add tests for expected statsd reports during a content replay session

1 unresolved thread

Also include the revision:

Small code refactoring in test_cli

make '_fill_objstorage_and_kafka()' take the actual objstorage as argument, instead of the dict of objstorages ("src", "dst"). The "dst" objstorage is not used in the function, and it make the intent of this later clearer.


Migrated from D6724 (view on Phabricator)

Merge request reports

Closed by Phabricator Migration userPhabricator Migration user 3 years ago (Dec 2, 2021 12:11pm UTC)

Merge details

  • The changes were not merged into generated-differential-D6724-target.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
10
11 from swh.journal.client import JournalClient
12 from swh.journal.writer import get_journal_writer
13 from swh.model.model import Content
14 from swh.objstorage.factory import get_objstorage
15 from swh.objstorage.replayer import replay
16 from swh.objstorage.replayer.replay import process_replay_objects_content
17
18
19 @pytest.fixture
20 def statsd(monkeypatch, statsd):
21 monkeypatch.setattr(replay, "statsd", statsd)
22 yield statsd
23
24
25 def test_replay_statsd(kafka_server, kafka_prefix, kafka_consumer_group, statsd):
  • Nicolas Dandrimont mentioned in merge request !10 (closed)

    mentioned in merge request !10 (closed)

  • Thanks!

  • Merge request was accepted

  • Nicolas Dandrimont approved this merge request

    approved this merge request

  • Author Maintainer

    typo and small improvement in the test

  • Build is green

    Patch application report for D6724 (id=24433)

    Rebasing onto 720b7af2...

    Current branch diff-target is up to date.
    Changes applied before test
    commit 1d8ea80c7d01847dba16343508b74a037a1da864
    Author: David Douard <david.douard@sdfa3.org>
    Date:   Wed Dec 1 17:28:56 2021 +0100
    
        Add tests for expected statsd reports during a content replay session
    
    commit 002443567791de9ffef1a2b443eb7471d120bebe
    Author: David Douard <david.douard@sdfa3.org>
    Date:   Thu Nov 25 17:36:27 2021 +0100
    
        Small code refactoring in test_cli
        
        make '_fill_objstorage_and_kafka()' take the actual objstorage as
        argument, instead of the dict of objstorages ("src", "dst"). The "dst"
        objstorage is not used in the function, and it make the intent of this
        later clearer.

    See https://jenkins.softwareheritage.org/job/DOBJSRPL/job/tests-on-diff/21/ for more details.

  • Author Maintainer

    Merge request was merged

  • closed

  • Please register or sign in to reply
    Loading