tests: Use Path objects instead of bytes (and update from_disk to support it)

And replace a few instances of open().write(...) which never triggered file closing with Path.write_text(...) so they don't rely on CPython-specific behavior

This complements @marmoute's work in !354 (merged)

Jenkins job DMOD/gitlab-builds #152 succeeded .
See Console Output and Coverage Report for more details.

added 1 commit

• e8dbb532 - tests: Use Path objects instead of bytes

Compare with previous version

Jenkins job DMOD/gitlab-builds #156 succeeded .
See Console Output and Coverage Report for more details.

Shouldn't the usage of bytes in from_disk methods be deprecated then?

(BTW the title of the MR is a bit misleading; need to see actual revisions to get the picture)

Shouldn't the usage of bytes in from_disk methods be deprecated then?

Probably, yes. But I'd like to properly migrate it to pathlib first instead of doing path = bytes(path) at the beginning of the function.

(BTW the title of the MR is a bit misleading; need to see actual revisions to get the picture)

yeah, the changes to from_disk happened as a consequence to test changes

changed title from tests: Use Path objects instead of bytes to tests: Use Path objects instead of bytes (and update from_disk to support it)

added 17 commits

• e8dbb532...34f61010 - 16 commits from branch master
• 9c56626a - Merge branch 'master' into pathlib

Compare with previous version

Jenkins job DMOD/gitlab-builds #174 succeeded .
See Console Output and Coverage Report for more details.