Add an optional type field on OriginVisitStatus object

The optional nature of the type will allow to avoid migrating the (db) data model right now then we can have this type field in kafka messages in the origin-visit-status topic

Related to swh-scheduler#2443 (closed) Related to #2963 (closed)

---

Migrated from D4848 (view on Phabricator)

Build is green

Patch application report for D4848 (id=17159)

Rebasing onto 18fde504...

Current branch diff-target is up to date.

Changes applied before test

commit 69347b665aed8301466dc278c67c40d1e8ee77b4
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date:   Tue Jan 12 18:07:04 2021 +0100

    Add an optional type field on OriginVisitStatus object
    
    The optional nature of the type will allow to avoid migrating the
    (db) data model right now then we can have this type field in kafka
    messages in the origin-visit-status topic
    
    Related to swh/devel/swh-scheduler#2443

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/197/ for more details.

mentioned in commit swh-storage@0b44b372

Remove unnecessary changes on tests

Build is green

Patch application report for D4848 (id=17165)

Rebasing onto 1d0c3212...

First, rewinding head to replay your work on top of it...
Applying: Add an optional type field on OriginVisitStatus object

Changes applied before test

commit 13cca00f1ddebf4aaaa1798b6fc7bb1cc37b738a
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date:   Tue Jan 12 18:07:04 2021 +0100

    Add an optional type field on OriginVisitStatus object
    
    The optional nature of the type will allow to avoid migrating the
    (db) data model right now then we can have this type field in kafka
    messages in the origin-visit-status topic
    
    Related to swh/devel/swh-scheduler#2443

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/198/ for more details.

Could you add a comment in model.py explaining why it's optional?

Heads up, swh-storage!632 (closed) got landed with a restriction on hypothesis < 6 in storage's requirements.

Heads up, swh-storage!632 (closed) got landed with a restriction on hypothesis < 6 in storage's requirements.

wrong diff, sorry for the noise.

Some references in the commit message have been migrated:

• T2443 is now swh-scheduler#2443 (closed)

Add a comment to explain why the field type is optional

Build is green

Patch application report for D4848 (id=17174)

Rebasing onto 1d0c3212...

Current branch diff-target is up to date.

Changes applied before test

commit 1ca92a5ce003d5e52b028dc9c6c79b6aacc1071e
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date:   Tue Jan 12 18:07:04 2021 +0100

    Add an optional type field on OriginVisitStatus object
    
    The optional nature of the type will allow to avoid migrating the
    (db) data model right now then we can have this type field in kafka
    messages in the origin-visit-status topic
    
    Related to swh/devel/swh-scheduler#2443

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/199/ for more details.

mentioned in merge request swh-scheduler!170 (closed)

mentioned in merge request swh-scheduler!171 (closed)

mentioned in merge request swh-journal!195 (closed)

mentioned in merge request swh-storage!633 (closed)

mentioned in merge request swh-scheduler!175 (closed)

Merge request was accepted

approved this merge request

Merge request was merged

closed