model: Raise error on naive datetimes.

We may unknowingly pass naive datetimes to the storage through them, causing the underlying DB to assign them a timezone that might not match the actual one.

It already happens in swh.model and swh.loader.package tests.

---

Migrated from D3793 (view on Phabricator)

Build is green

Patch application report for D3793 (id=13312)

Rebasing onto d1db7b99...

Current branch diff-target is up to date.

Changes applied before test

commit 6dd6acecc8297f8c9f77bdae0ccd291ceabdfd8e
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Aug 14 14:12:29 2020 +0200

    model: Raise error on naive datetimes.
    
    We may unknowingly pass naive datetimes to the storage through them,
    causing the underlying DB to assign them a timezone that might not match
    the actual one.
    
    It already happens in swh.model and swh.loader.package tests.

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/132/ for more details.

Indeed, it seems a good idea to restrict naive dates.

Merge request was accepted

approved this merge request

Merge request was merged

closed