identifiers: Make invalid persistent identifier parsing raise error

So far we accept any kinds of persistent identifier, including invalid ones. We should raise instead.

Related #1104 (closed)

Before, for example:

$ python3
In [1]: from swh.model.identifiers import parse_persistent_identifier
In [2]: parse_persistent_identifier('foo')
Out[2]: {'namespace': 'foo', 'scheme_version': {}}

Now:

$ python3
Python 3.6.6rc1 (default, Jun 13 2018, 06:59:48)
[GCC 8.1.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from swh.model.identifiers import parse_persistent_identifier
>>> parse_persistent_identifier('foo')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/tony/work/inria/repo/swh/swh-environment/swh-model/swh/model/identifiers.py", line 677, in parse_persistent_identifier
    'Wrong format: There should be 4 mandatory parameters')
swh.model.identifiers.SWHMalformedIdentifierException: Wrong format: There should be 4 mandatory parameters

Test Plan

Tests should still pass

---

Migrated from D346 (view on Phabricator)

• identifiers: Raise when invalid contextual data in persistent id

As per discussion with anlambert, converge towards the existing swh-web utils code [1]

• [1] https://forge.softwareheritage.org/source/swh-web/browse/master/swh/web/common/utils.py$254

• identifiers: Also validate the hash is correct

• identifiers: Fix wrong type in docstring

• identifiers: Permit to pass directly the object's id to persistent_identifier api

As per discussion with anlambert, converge towards the existing swh-web utils code [1]

Clarifying, the webapp's utils code is a 'duplicate' that will possibly become an adapter of the api here. Probably delegating the parsing to the swh.model function, and possibly transforming any exceptions raised during parsing into the needed swh.web ones. So that, everything continues working as expected in the swh.web module.

• swh.model.cli: Catch specific exception during identifiers check

mentioned in merge request swh-web!52 (closed)

Merge request was accepted

approved this merge request

Merge request was returned for changes

mentioned in commit bd22f277

• identifiers: Validate that inputs are correct
• identifiers: Reuse ValidationError exception + update docstring

All concerns have been addressed. This is already merged and improved through:

bd22f277 f2422d65 dfb128e9 b6073e27 79d57ac7 7779c573 0d3a0514 8a0cc22a

Merge request was abandoned

closed