Tag model entities with their "object_type"
this aims at preventing constant usage of isinstance() based dispatch code when writing generic code handling model entities. For example, the "object_type" argument of JournalWriter.write_addition() has become superflous now we only pass model entities, etc. This idea comes olasd's reading of mypy doc: https://mypy.readthedocs.io/en/latest/literal_types.html#tagged-unions This comes with a refactoring of from_dict.DiskBackedContent to make it *not* inherit from model.Content: object_type being Final, it cannot be overloaded.
parent
661b7c2c
No related branches found
No related tags found
# Add here external Python modules dependencies, one per line. Module names | ||
# should match https://pypi.python.org/pypi names. For the full spec or | ||
# dependency lines, see https://pip.readthedocs.org/en/1.1/requirements.html | ||
vcversioner | ||
attrs | ||
attrs_strict >= 0.0.7 | ||
hypothesis | ||
python-dateutil | ||
iso8601 | ||
python-dateutil | ||
typing_extensions | ||
vcversioner |
-
mentioned in merge request !275 (closed)
-
mentioned in merge request !252 (closed)
Please register or sign in to comment