Skip to content
Snippets Groups Projects

More fixes related to externals handling

Merged Antoine Lambert requested to merge anlambert/swh-loader-svn:more-external-bug-fixes into master
All threads resolved!

That MR contains two commits with the following fixes:

  • If an external definition targets an URL whose starts with 'svn+ssh://@', the checkout or export operation is blocking due to SSH password prompt triggered by such URL.

    So ensure to automatically set the requested password to 'anonymous' to avoid blocking when attempting to export such external.

  • Previous implementation of is_recursive_external detected some false positive cases which were leading to hash mismatches when checking revisions.

This fixes the full loading of https://svn.code.sf.net/p/contrap/code.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • vlorentz
  • Antoine Lambert added 7 commits

    added 7 commits

    • 285e04f7...c48f388b - 5 commits from branch swh/devel:master
    • e75d0bd5 - svn_repo: Prevent blocking checkout or export operation
    • fe098274 - utils: Refine detection of recursive external definition

    Compare with previous version

  • Antoine Lambert resolved all threads

    resolved all threads

  • Jenkins job DLDSVN/gitlab-builds #226 succeeded in 4 min 7 sec.
    See Console Output, Blue Ocean and Coverage Report for more details.

  • Antoine R. Dumont approved this merge request

    approved this merge request

  • Antoine Lambert merged manually

    merged manually

  • Please register or sign in to reply
    Loading