test_loader: Fix implementation of test_loader_with_ref_delta_in_pack

Previous implementation was building an invalid pack file with REF_DELTA object types as it was using the new object to deltify as the base of the delta.

This was leading to errors and undefined behavior after building an index for such a pack file as the deltified objects could not be properly resolved by dulwich (observed by stsp while working on git loader improvements).

The bases for deltified objects are now objects that were previously loaded into the archive.

Cc. @stsp

Jenkins job DLDG/gitlab-builds #180 succeeded .
See Console Output and Coverage Report for more details.

added 2 commits

• a8a5077a - 1 commit from branch swh/devel:master
• b536269a - test_loader: Fix implementation of test_loader_with_ref_delta_in_pack

Compare with previous version

Jenkins job DLDG/gitlab-builds #183 succeeded .
See Console Output and Coverage Report for more details.

Looks good to me, thanks!

My bad for this, I misunderstood the REF_DELTA meaning when I implemented that test. I also noticed that the Tag objects produced by the test were invalid so I also fixed them.

added 1 commit

• 39d38c4e - test_loader: Fix implementation of test_loader_with_ref_delta_in_pack

Compare with previous version

enabled an automatic merge when the pipeline for 39d38c4e succeeds

Jenkins job DLDG/gitlab-builds #184 succeeded .
See Console Output and Coverage Report for more details.

merged