Skip to content

Don't assume all GitClient instances have a 'dumb' attribute

vlorentz requested to merge generated-differential-D7835-source into generated-differential-D7835-target

Only instances of (subclasses of) AbstractHttpGitClient have this attribute.

For other instances, we can consider it to be False, because the dumb protocol only exists over HTTP(S).

This issue was found by mypy, thanks to the addition of type annotations to changes in dulwich 0.20.36 affecting mypy's type inference.

Migrated from D7835 (view on Phabricator)

Merge request reports