add tests to git loader
as per title: the Git loader is a key component of our in-production toolchain, we should really have tests around at least its basic ingestion logic
Migrated from T1219 (view on Phabricator)
Designs
- Show closed items
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Stefano Zacchiroli mentioned in merge request !17 (closed)
mentioned in merge request !17 (closed)
- Stefano Zacchiroli mentioned in merge request !18 (closed)
mentioned in merge request !18 (closed)
- Stefano Zacchiroli added Git loader Sprint 2018 12 priority:High labels
added Git loader Sprint 2018 12 priority:High labels
- Phabricator Migration user mentioned in commit caf409fb
mentioned in commit caf409fb
Resolved by !10 (closed).
- vlorentz closed
closed
- Author Maintainer
! In #1219 (closed), @vlorentz wrote: Resolved by !10 (closed).
Based on https://jenkins.softwareheritage.org/view/swh%20master/job/DLDG/job/tests/5/cobertura/loader_git/ I'd argue that tests has been added to the loader part of git-loader, but not to the updater part of it, which is what is used mostly in production (yes, it's an historical misnomer, and I really wish that the two could be merged, but that's unrelated to #1219 (closed)…).
So either we keep this task open as WIP status, or we add a new dedicated one to keep track that the git "updater" needs tests.
- vlorentz reopened
reopened
- Phabricator Migration user mentioned in commit c7bf9e26
mentioned in commit c7bf9e26
- Phabricator Migration user marked this issue as related to swh-environment#1411 (closed)
marked this issue as related to swh-environment#1411 (closed)
- Phabricator Migration user mentioned in commit 65f740c8
mentioned in commit 65f740c8
- Antoine R. Dumont assigned to @ardumont and unassigned @vlorentz
- Antoine R. Dumont added state:wip label
added state:wip label
- Phabricator Migration user mentioned in commit 5c274a58
mentioned in commit 5c274a58
- Maintainer
Up to 85% now.
- Antoine R. Dumont removed state:wip label
removed state:wip label
- Antoine R. Dumont closed
closed
- Antoine R. Dumont added priority:Triage label and removed priority:High label
added priority:Triage label and removed priority:High label