Skip to content

loader: Stop materializing full lists of objects to be stored.

vlorentz requested to merge generated-differential-D3976-source into generated-differential-D3976-target

Since rDLDBASE43728c596498979cd5083b61e93360b4c2071c31, store_data consumes the entire iterator of contents, and since 3b97703d, it does the same for other object types.

This causes all the (new) objects of the loaded repository to be loaded in memory at the same time before being sent to the storage, which can cause OOM errors.

Instead, with this commit, objects are added one by one to the storage, which restores the lazy behavior we had before these two commits using the buffered storage proxy.

Resolves swh-loader-git#2373 (closed).

Migrated from D3976 (view on Phabricator)

Merge request reports