Skip to content

loader: Ensure success is False when entering exception handler

Antoine Lambert requested to merge generated-differential-D7833-source into generated-differential-D7833-target

The post_load method of a loader can raise an exception so we must ensure to turn back the success variable to False in that case.

For instance, the subversion loader post_load checks that latest exported revision is consistent with what the official subversion client produces. If it is not an exception will be raised to set the visit status to partial.

See https://jenkins.softwareheritage.org/job/DENV/job/tests/2538/artifact/swh-loader-svn.log

Migrated from D7833 (view on Phabricator)

Merge request reports