loader/opam/tests: Do not run actual opam init command call

Instead, this fixes the pseudo fake opam root present in tests datadir folder to the right structure and then installs it properly for the test to use.

Another benefit from this is now inhibiting any actual network happening during the opam init cli call.

This also reverts the previous commit which added a --yes in the opam init cli. This was not working and not the right solution in the end.

Related to swh/infra/sysadm-environment#3973 (closed)

Test Plan

tox

---

Migrated from D7255 (view on Phabricator)

Build has FAILED

Patch application report for D7255 (id=26287)

Rebasing onto ec6591f6...

Current branch diff-target is up to date.

Changes applied before test

commit eff49575a690e13e553e3c827cdf60b4f0497404
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Feb 25 10:06:43 2022 +0100

    loader/opam/tests: Do not run actual opam init command call
    
    Instead, this fixes the pseudo fake opam root present in tests datadir folder to the
    right structure and then installs it properly for the test to use.
    
    Another benefit from this is now inhibiting any actual network happening during the opam
    init cli call.
    
    This also reverts the previous commit which added a --yes in the opam init cli.
    This was not working and not the right solution in the end.
    
    Related to swh/infra/sysadm-environment#3973

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/698/ See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/698/console

Some references in the commit message have been migrated:

• T3973 is now swh/infra/sysadm-environment#3973 (closed)

Fix tests for python3.7

Build is green

Patch application report for D7255 (id=26288)

Rebasing onto ec6591f6...

Current branch diff-target is up to date.

Changes applied before test

commit 5c11fe2ef48b410edc8a0da890300118a87ffdfb
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Feb 25 10:06:43 2022 +0100

    loader/opam/tests: Do not run actual opam init command call
    
    Instead, this fixes the pseudo fake opam root present in tests datadir folder to the
    right structure and then installs it properly for the test to use.
    
    Another benefit from this is now inhibiting any actual network happening during the opam
    init cli call.
    
    This also reverts the previous commit which added a --yes in the opam init cli.
    This was not working and not the right solution in the end.
    
    Related to swh/infra/sysadm-environment#3973

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/699/ for more details.

Merge request was merged

closed

mentioned in issue #3976