debian: Fix confusion between the two versions

'version' was documented as the intrinsic version (eg. '0.7.2-3') and 'full_version' as the one containing the suite name (eg. 'stretch/contrib/0.7.2-3').

In practice, it was the opposite, except in a few incorrect test.

This commit fixes said tests, and renamed 'full_version' to 'intrinsic_version'.

This is only a refactoring, the behavior is unchanged for now; but a future commit will remove the 'version' (which is extrinsic) from the release name (which should contain only data intrinsic to the DSC).

---

Migrated from D6748 (view on Phabricator)

Build is green

Patch application report for D6748 (id=24507)

Rebasing onto 5d22455c...

Current branch diff-target is up to date.

Changes applied before test

commit 379ff90b7703f7c8e8dc2faa97713641d7e21757
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Dec 6 13:48:04 2021 +0100

    debian: Fix confusion between the two versions
    
    'version' was documented as the intrinsic version (eg. '0.7.2-3') and
    'full_version' as the one containing the suite name (eg. 'stretch/contrib/0.7.2-3').
    
    In practice, it was the opposite, except in a few incorrect test.
    
    This commit fixes said tests, and renamed 'full_version' to
    'intrinsic_version'.
    
    This is only a refactoring, the behavior is unchanged for now;
    but a future commit will remove the 'version' (which is extrinsic) from
    the release name (which should contain only data intrinsic to the DSC).

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/641/ for more details.

update the doc accordingly

oops, I confused the names again in the doc

Build is green

Patch application report for D6748 (id=24508)

Rebasing onto 5d22455c...

Current branch diff-target is up to date.

Changes applied before test

commit c469149b77c57c8df75bf1e51a6919cd3294747e
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Dec 6 13:48:04 2021 +0100

    debian: Fix confusion between the two versions
    
    'version' was documented as the intrinsic version (eg. '0.7.2-3') and
    'full_version' as the one containing the suite name (eg. 'stretch/contrib/0.7.2-3').
    
    In practice, it was the opposite, except in a few incorrect test.
    
    This commit fixes said tests, and renamed 'full_version' to
    'intrinsic_version'.
    
    This is only a refactoring, the behavior is unchanged for now;
    but a future commit will remove the 'version' (which is extrinsic) from
    the release name (which should contain only data intrinsic to the DSC).

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/642/ for more details.

Build is green

Patch application report for D6748 (id=24509)

Rebasing onto 5d22455c...

Current branch diff-target is up to date.

Changes applied before test

commit 958674dc24171ced169397054ffb1502b60f7f43
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Dec 6 13:48:04 2021 +0100

    debian: Fix confusion between the two versions
    
    'version' was documented as the intrinsic version (eg. '0.7.2-3') and
    'full_version' as the one containing the suite name (eg. 'stretch/contrib/0.7.2-3').
    
    In practice, it was the opposite, except in a few incorrect test.
    
    This commit fixes said tests, and renamed 'full_version' to
    'intrinsic_version'.
    
    This is only a refactoring, the behavior is unchanged for now;
    but a future commit will remove the 'version' (which is extrinsic) from
    the release name (which should contain only data intrinsic to the DSC).

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/643/ for more details.

Looks good to me.

mentioned in merge request !246 (closed)

Merge request was accepted

approved this merge request

Thank you!

rebase

Build is green

Patch application report for D6748 (id=24537)

Rebasing onto 2d9e93a2...

Current branch diff-target is up to date.

Changes applied before test

commit 26996ef3eef494eb187e01b999255cfa101ad758
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Dec 6 13:48:04 2021 +0100

    debian: Fix confusion between the two versions
    
    'version' was documented as the intrinsic version (eg. '0.7.2-3') and
    'full_version' as the one containing the suite name (eg. 'stretch/contrib/0.7.2-3').
    
    In practice, it was the opposite, except in a few incorrect test.
    
    This commit fixes said tests, and renamed 'full_version' to
    'intrinsic_version'.
    
    This is only a refactoring, the behavior is unchanged for now;
    but a future commit will remove the 'version' (which is extrinsic) from
    the release name (which should contain only data intrinsic to the DSC).

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/649/ for more details.

Merge request was merged

closed