package.tests: Fix failure caused by wrong order of visit IDs

The in-mem/cass storage used to sort visits by (id, date). The last releases now sort by (date, id) like postgresql, but this test did not expect it.

This commit instantiate the loader after picking a date for the dummy visit, so the loader's visit always comes after the dummy one.

---

Migrated from D6164 (view on Phabricator)

fix commit

fix commit

Build has FAILED

Patch application report for D6164 (id=22324)

Rebasing onto 63a8a61c...

Current branch diff-target is up to date.

Changes applied before test

commit 14ffb7ef5f520448a21543ee717a07a19a4e6a10
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Aug 31 10:36:54 2021 +0200

    package.tests: Fix failure caused by wrong order of visit IDs
    
    The in-mem/cass storage used to sort visits by (id, date).
    The last releases now sort by (date, id) like postgresql, but
    this test did not expect it.
    
    This commit instantiate the loader *after* picking a date
    for the dummy visit, so the loader's visit always comes after
    the dummy one.

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/517/ See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/517/console

Build is green

Patch application report for D6164 (id=22325)

Rebasing onto 63a8a61c...

Current branch diff-target is up to date.

Changes applied before test

commit 50b062adc7946490c76a252f6eb356811930cb12
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Aug 31 10:36:54 2021 +0200

    package.tests: Fix failure caused by wrong order of visit IDs
    
    The in-mem/cass storage used to sort visits by (id, date).
    The last releases now sort by (date, id) like postgresql, but
    this test did not expect it.
    
    This commit instantiate the loader *after* picking a date
    for the dummy visit, so the loader's visit always comes after
    the dummy one.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/518/ for more details.

Build is green

Patch application report for D6164 (id=22326)

Rebasing onto 63a8a61c...

Current branch diff-target is up to date.

Changes applied before test

commit 50b062adc7946490c76a252f6eb356811930cb12
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Aug 31 10:36:54 2021 +0200

    package.tests: Fix failure caused by wrong order of visit IDs
    
    The in-mem/cass storage used to sort visits by (id, date).
    The last releases now sort by (date, id) like postgresql, but
    this test did not expect it.
    
    This commit instantiate the loader *after* picking a date
    for the dummy visit, so the loader's visit always comes after
    the dummy one.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/519/ for more details.

Merge request was accepted

approved this merge request

Merge request was merged

closed