deposit: Update status_detail on loader failure

So far, it was only updated on checker failure. However, many failures may happen while loading, and we had no way to report them to users so far (besides diving ourselves in the logs/Sentry)

Written with @ardumont

---

Migrated from D6079 (view on Phabricator)

Build is green

Patch application report for D6079 (id=22013)

Rebasing onto 6118d43e...

Current branch diff-target is up to date.

Changes applied before test

commit 462a195ca294c45a0b7fe95b4b3e9901229215bc
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Aug 12 11:06:51 2021 +0200

    deposit: Update status_detail on loader failure
    
    So far, it was only updated on checker failure.
    However, many failures may happen while loading, and we had no
    way to report them to users so far (besides diving ourselves
    in the logs/Sentry)

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/505/ for more details.

mentioned in merge request swh-deposit!263 (closed)

Looks good to me.

This also requires some update on the deposit side. It's ongoing work.

Merge request was accepted

approved this merge request

fix type of status_detail

fix type of status_detail

Build has FAILED

Patch application report for D6079 (id=22016)

Rebasing onto 6118d43e...

Current branch diff-target is up to date.

Changes applied before test

commit 53087b5b53fa59708937bb5344ea2006dab3e10f
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Aug 12 11:06:51 2021 +0200

    deposit: Update status_detail on loader failure
    
    So far, it was only updated on checker failure.
    However, many failures may happen while loading, and we had no
    way to report them to users so far (besides diving ourselves
    in the logs/Sentry)

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/506/ See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/506/console

Build is green

Patch application report for D6079 (id=22015)

Rebasing onto 573df1cc3d...

Current branch diff-target is up to date.

Changes applied before test

commit 737838e772c8b1aa3e8766b2927d0391337695a9
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Aug 12 11:27:51 2021 +0200

    deposit_update_status: Add support for updating status_detail
    
    This will be used by the deposit loader in case of failure,
    to tell users what the actual error is.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/673/ for more details.

fix test

Build is green

Patch application report for D6079 (id=22018)

Rebasing onto 6118d43e...

Current branch diff-target is up to date.

Changes applied before test

commit 63a8a61cbc9837db5851c267a02838f886384a24
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Aug 12 11:06:51 2021 +0200

    deposit: Update status_detail on loader failure
    
    So far, it was only updated on checker failure.
    However, many failures may happen while loading, and we had no
    way to report them to users so far (besides diving ourselves
    in the logs/Sentry)

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/507/ for more details.

Merge request was merged

closed