core.loader: Actually still allow to pass configuration through constructor

This is still used within tests of the webapp (and vault i think) [1].

• [1] I see both build are broken due to this (they use the loader-git in their tests)

Test Plan

tox

---

Migrated from D4132 (view on Phabricator)

Build is green

Patch application report for D4132 (id=14560)

Rebasing onto 5e4fd64d...

Current branch diff-target is up to date.

Changes applied before test

commit fd458b7d62ca45614371a0923db29d2e6c021151
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 2 15:15:58 2020 +0200

    core.loader: Actually still allow to pass configuration through constructor
    
    This is still used within tests of the webapp and vault.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/318/ for more details.

Add tests around the code

Build is green

Patch application report for D4132 (id=14565)

Rebasing onto de1db963...

Current branch diff-target is up to date.

Changes applied before test

commit c7451b918012a2c7196b704d9cdcba4285a731ad
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 2 15:15:58 2020 +0200

    core.loader: Actually still allow to pass configuration through constructor
    
    This is still used within tests of the webapp and vault.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/319/ for more details.

Add a second test on the DVCSLoader as well

Build is green

Patch application report for D4132 (id=14566)

Rebasing onto de1db963...

Current branch diff-target is up to date.

Changes applied before test

commit 2740208d377933ad16edae9824b86a08246889af
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 2 15:15:58 2020 +0200

    core.loader: Actually still allow to pass configuration through constructor
    
    This is still used within tests of the webapp and vault.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/320/ for more details.

Merge request was accepted

approved this merge request

Rebase

Build is green

Patch application report for D4132 (id=14569)

Rebasing onto 9f7d629d...

Current branch diff-target is up to date.

Changes applied before test

commit 64f2361c85ebd0eddddd4edc983b7e0333ff12da
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 2 16:49:26 2020 +0200

    core.loader: Allow config parameter passing through constructor

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/321/ for more details.

Merge request was merged

closed