Update the revision metadata field as an immutable dict
Closed
requested to merge generated-differential-D3471-source into generated-differential-D3471-target
1 unresolved thread
If that makes sense.
Either that or we need to push down the original_artifact part into the different package loader implementations.
Fix build [1]
Test Plan
tox
Migrated from D3471 (view on Phabricator)
Merge request reports
Activity
Build is green
Patch application report for D3471 (id=12273)
Rebasing onto 488b515a...
Current branch diff-target is up to date.Changes applied before test
commit 8762b61d6a3c06058a2fc3e1b8b8279ffe79556a Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org> Date: Wed Jul 8 18:10:00 2020 +0200 Update the revision metadata field as an immutable dict Fix build [1] - [1] https://jenkins.softwareheritage.org/job/DLDBASE/job/tests/919/consoleSee https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/117/ for more details.
422 423 # skipping those 423 424 return None 424 425 425 metadata = revision.metadata or {} 426 metadata.update( 427 {"original_artifact": [hashes for _, hashes in dl_artifacts],} 426 extra_metadata: Tuple[str, Any] = ( 427 "original_artifact", 428 [hashes for _, hashes in dl_artifacts], 428 429 ) 429 revision = attr.evolve(revision, metadata=metadata) 430 if revision.metadata is not None: 431 full_metadata = list(revision.metadata.items()) + [extra_metadata] 432 else: 433 full_metadata = [extra_metadata] -
Build is green
Patch application report for D3471 (id=12277)
Rebasing onto 488b515a...
Current branch diff-target is up to date.Changes applied before test
commit 6dc3da1580d9d35cc9e7478f134b5246e058dc78 Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org> Date: Wed Jul 8 18:10:00 2020 +0200 Update the revision metadata field as an immutable dict Fix build [1] - [1] https://jenkins.softwareheritage.org/job/DLDBASE/job/tests/919/consoleSee https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/118/ for more details.
Please register or sign in to reply