Skip to content
Snippets Groups Projects

bitbucket: Allow to specify the number of repos per api request

2 unresolved threads

This is independent but still, it somehow fixes the issue occurring on #1826 (closed) (at least for the full lister... which is weird...)

Related #1826 (closed)

Depends on !74 (closed) Depends on !75 (closed)

Test Plan

tox docker-dev


Migrated from D1631 (view on Phabricator)

Merge request reports

Approved by

Closed by Phabricator Migration userPhabricator Migration user 5 years ago (Jun 21, 2019 3:58pm UTC)

Merge details

  • The changes were not merged into generated-differential-D1631-target.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
76 86 else:
77 87 ret = lower <= inner <= upper
78 88 except Exception as e:
79 logger.error(str(e) + ': %s, %s, %s' %
80 (('inner=%s%s' % (type(inner), inner)),
81 ('lower=%s%s' % (type(lower), lower)),
82 ('upper=%s%s' % (type(upper), upper)))
83 )
89 logger.error(str(e) + ': %s, %s, %s',
90 ('inner=%s%s' % (type(inner), inner)),
91 ('lower=%s%s' % (type(lower), lower)),
92 ('upper=%s%s' % (type(upper), upper)))
  • 17 17
    18 DEFAULT_BITBUCKET_PAGE = 10
    19
    20
    18 21 class BitBucketLister(IndexingHttpLister):
    19 22 PATH_TEMPLATE = '/repositories?after=%s'
    20 23 MODEL = BitBucketModel
    21 24 LISTER_NAME = 'bitbucket'
    22 25 instance = 'bitbucket'
    23 26
    27 def __init__(self, api_baseurl, override_config=None, per_page=100):
    28 super().__init__(
    29 api_baseurl=api_baseurl, override_config=override_config)
    30 if per_page != DEFAULT_BITBUCKET_PAGE:
    31 self.PATH_TEMPLATE = '%s&pagelen=%s' % (
    32 self.PATH_TEMPLATE, per_page)
  • Merge request was accepted

  • Nicolas Dandrimont approved this merge request

    approved this merge request

  • Build has FAILED

    oh, that's why i did not open it earlier ;) nice catch jenkins, thanks.

  • Fix tests

  • Fix one level of parentheses too many

  • Merge request was merged

  • Please register or sign in to reply
    Loading