Skip to content
Snippets Groups Projects

github: Ensure range listers do not override shared lister state

Recent changes in base Lister class implementation turn the call to self.scheduler.update_lister mandatory to update the last termination date for a lister.

It has some side effects on the GitHub lister as there is one incremental instance plus multiple range ones relisting previously discovered repos executed in parallel.

Range GitHub listers should not override the shared incremental lister state as StaleData exceptions might be raised otherwise, so override the set_state_in_scheduler Lister method to ensure that.

Fixes SWH-LISTER-EM

Merge request reports

Pipeline #11741 passed

Pipeline passed for 88a715d0 on anlambert:github-relister-no-state-update

Approval is optional

Merged by Antoine LambertAntoine Lambert 5 months ago (Oct 28, 2024 3:42pm UTC)

Merge details

  • Changes merged into with 88a715d0.
  • Deleted the source branch.

Pipeline #11742 passed

Pipeline passed for 88a715d0 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading