lister: Allow lister to build url out of the instance parameter

This pushes the rather elementary logic within the lister's scope. This will simplify and unify cli call between lister and scheduler clis. This will also allow to reduce erroneous operations which can happen for example in the add-forge-now. We will then only have to provide the type and the instance, and everything will be scheduled properly.

@gsamson from a discussion a while back ;)

Refs. #4693

changed the description

Jenkins job DLS/gitlab-builds #60 succeeded .
See Console Output and Coverage Report for more details.

LGTM, I added a couple of inline comments.

I am also wondering if we should not enforce the instance parameter to be a net location, meaning if we urlparse it and there is a scheme, either we throw an error either we extract the net location.

changed the description

I am also wondering if we should not enforce the instance parameter to be a net location, meaning if we urlparse it and there is a scheme, either we throw an error either we extract the net location.

sounds good. Let's raise so the user knows it's wrong and fix it in the next call (instead of complying with somewhat "bad" input).

resolved all threads

added 1 commit

• 09fca5f5 - lister: Allow lister to build url out of the instance parameter

Compare with previous version

added 1 commit

• a4560551 - lister: Allow lister to build url out of the instance parameter

Compare with previous version

added 1 commit

• da017a15 - lister: Allow lister to build url out of the instance parameter

Compare with previous version

approved this merge request

added 1 commit

• 19bdeefb - lister: Allow lister to build url out of the instance parameter

Compare with previous version

merged