pattern: Use URL network location as instance name when not provided
Closed
requested to merge generated-differential-D5989-source into generated-differential-D5989-target
Make the instance parameter of the base pattern lister optional and set lister name to URL network location when not provided.
It simplifies lister creation when associated forge type have a lot of instances in the wild (e.g. gitlab or cgit) while giving more details about the listed forge instance.
Also process listers for forge with multiple instances (cgit, gitea, gitlab, phabricator and tuleap) to ensure URL network location will be used when instance parameter is not provided.
Related to T3403
Migrated from D5989 (view on Phabricator)
Merge request reports
Activity
Some references in the commit message have been migrated:
- T3403 is now swh/meta#3403 (closed)
Build is green
Patch application report for D5989 (id=21615)
Rebasing onto df46b220...
Current branch diff-target is up to date.
Changes applied before test
commit 6c123508634c6467b2fb9be83de69e6a5e77363a Author: Antoine Lambert <anlambert@softwareheritage.org> Date: Tue Jul 13 12:33:41 2021 +0200 pattern: Use URL network location as instance name when not provided Make the instance parameter of the base pattern lister optional and set lister name to URL network location when not provided. It simplifies lister creation when associated forge type have a lot of instances in the wild (e.g. gitlab or cgit) while giving more details about the listed forge instance. Also process listers for forge with multiple instances (cgit, gitea, gitlab, phabricator and tuleap) to ensure URL network location will be used when instance parameter is not provided. Related to [T3403](https://forge.softwareheritage.org/T3403 'view original for T3403 on Phabricator')
See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/331/ for more details.
Please register or sign in to reply