cgit: Compute origin urls out of a base git url when provided.

This adds a second behavior to the cgit lister to actually compute origin urls instead of parsing them out of another http request on git detailed page (per repository listed).

This new behavior is expected to be the default behavior.

The old behavior is kept for now and is expected to be used as fallback if too much false negatives are returned.

(This is a requisite for the git.eclipse.org instance for example which cannot be listed otherwise [1]).

Related to #2999 (closed)

• [1] Related to T376#57560

---

Migrated from D4968 (view on Phabricator)

Build is green

Patch application report for D4968 (id=17741)

Rebasing onto 5aa7c8f2...

Current branch diff-target is up to date.

Changes applied before test

commit 14d47f1074ca16f1632b24fd416e86e51fee0354
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jan 29 11:38:26 2021 +0100

    cgit: Compute origin urls out of a base git url when provided.
    
    This adds a second behavior to the cgit lister to actually compute origin urls instead
    of parsing them out of another http request on git detailed page.
    
    This new behavior is expected to be the default behavior.
    
    The old behavior is kept for now and is expected to be used as fallback if too much
    false negatives are returned.
    
    Related to #2999

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/225/ for more details.

Update docstrings

Build is green

Patch application report for D4968 (id=17742)

Rebasing onto 5aa7c8f2...

Current branch diff-target is up to date.

Changes applied before test

commit 9a56097e1dfb1725a48371f208e89408eaaa7049
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jan 29 11:38:26 2021 +0100

    cgit: Compute origin urls out of a base git url when provided.
    
    This adds a second behavior to the cgit lister to actually compute origin urls instead
    of parsing them out of another http request on git detailed page.
    
    This new behavior is expected to be the default behavior.
    
    The old behavior is kept for now and is expected to be used as fallback if too much
    false negatives are returned.
    
    Related to #2999

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/226/ for more details.

The current implementation will not work for most cases where the base cgit URL and the base clone URL differs (see inline comment).

Also tasks parameters should be updated to handle the new one.

Merge request was returned for changes

Adapt according to review

Build is green

Patch application report for D4968 (id=17743)

Rebasing onto 5aa7c8f2...

Current branch diff-target is up to date.

Changes applied before test

commit e22d81d78d3e7a5fa30a6b0a2d025fa2375346f7
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jan 29 11:38:26 2021 +0100

    cgit: Compute origin urls out of a base git url when provided.
    
    This adds a second behavior to the cgit lister to actually compute origin urls instead
    of parsing them out of another http request on git detailed page.
    
    This new behavior is expected to be the default behavior.
    
    The old behavior is kept for now and is expected to be used as fallback if too much
    false negatives are returned.
    
    Related to #2999

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/227/ for more details.

Adapt according to review:

• Add more cgit instance samples
• Rework docstring
• Rework url computation a bit

Rework the lister docstring to clarify the 2nd behavior.

Build is green

Patch application report for D4968 (id=17749)

Rebasing onto 4cf0c7f7...

First, rewinding head to replay your work on top of it...
Applying: cgit: Compute origin urls out of a base git url when provided.

Changes applied before test

commit 8d989d3adabc5cf16c4397d09710b24a71836e8e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jan 29 11:38:26 2021 +0100

    cgit: Compute origin urls out of a base git url when provided.
    
    This adds a second behavior to the cgit lister to actually compute origin urls instead
    of parsing them out of another http request on git detailed page.
    
    This new behavior is expected to be the default behavior.
    
    The old behavior is kept for now and is expected to be used as fallback if too much
    false negatives are returned.
    
    Related to #2999

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/229/ for more details.

Looks good to me !

Merge request was accepted

approved this merge request

Some references in the commit message have been migrated:

• T2999 is now #2999 (closed)

Rebase

Build is green

Patch application report for D4968 (id=17750)

Rebasing onto 4cf0c7f7...

Current branch diff-target is up to date.

Changes applied before test

commit 2e220735581532f90755fc2fccefaf70a386ded0
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jan 29 11:38:26 2021 +0100

    cgit: Compute origin urls out of a base git url when provided.
    
    This adds a second behavior to the cgit lister to actually compute origin urls instead
    of parsing them out of another http request on git detailed page.
    
    This new behavior is expected to be the default behavior.
    
    The old behavior is kept for now and is expected to be used as fallback if too much
    false negatives are returned.
    
    Related to #2999

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/230/ for more details.

Merge request was merged

closed

mentioned in issue swh/meta#376 (closed)