lister: Type correctly the 'indexable' column

instead of converting that column as a string

As a side effect, bitbucket wise, we provided improperly the after query parameter as a date not url encoded. This resulted in improper api response from bitbucket's (we received from time to time the same next index as the current one).

Related #1826 (closed) Depends on !375 (closed)

---

Migrated from D1634 (view on Phabricator)

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tox/228/ See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tox/228/console

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tox/230/ See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tox/230/console

Improve dosctrings and logging instruction

Update docstrings and logging instructions

(fix) previous one (my emacs did not update the hash after rebase... and i did not see it immediately)

Build is green See https://jenkins.softwareheritage.org/job/DLS/job/tox/232/ for more details.

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tox/234/ See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tox/234/console

bitbucket: Improve pagination api traversal in corner cases

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tox/243/ See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tox/243/console

Fix docstring

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tox/244/ See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tox/244/console

Amend query parameters shenanigans (keep the old behavior)

It made sense to change that behavior at some point but no longer.

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tox/245/ See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tox/245/console

Update

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tox/249/ See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tox/249/console

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tox/254/ See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tox/254/console

Rebase

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tox/261/ See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tox/261/console

Build is green See https://jenkins.softwareheritage.org/job/DLS/job/tox/265/ for more details.

Rebase (tests ok)

Build is green See https://jenkins.softwareheritage.org/job/DLS/job/tox/269/ for more details.

indexable_type does not seem to be needed as a class attribute; and I'm not a fan of the name.

What about just a simple convert_type function, like you did for the test BB lister? And also do it for the actual BB lister (it uses iso8601.parse_date twice)

Merge request was returned for changes

indexable_type does not seem to be needed as a class attribute; and I'm not a fan of the name.

Yes, that name is inadequate. It's in reference to the (indexer) listers using the column indexable (which is inadequate as well). I did not want to push too far the fix though ;)

I'll rename the indexable_type to convert_type as suggested though.

Some references in the commit message have been migrated:

• T1826 is now #1826 (closed)

Update according to review

Build is green See https://jenkins.softwareheritage.org/job/DLS/job/tox/270/ for more details.

mentioned in issue #1826 (closed)

mentioned in issue #1849 (closed)

Merge request was accepted

approved this merge request

Merge request was merged

closed

mentioned in merge request !380 (closed)