opam: Directly use the --root flag instead of using an env variable

This aligns the behavior with the opam loader.

@aleo it's actually a good idea that I did this slight adaptations ;). Now I recall that for the deployment [1], it would work but often passing through the opamroot initialization step in the loader. Because, there is no guarantee that the actual worker listing the package (with a given opamroot as /tmp/<something>) will be the same one ingesting the package. Thus, the opamroot passed along to the loader may not exist, so it would get initialized and possibly multiple times.

We should probably make that opamroot a configuration entry in the dedicated configuration file targeting a fixed location in the workers to avoid the too many opamroot locations in /tmp (for another time/diff).

• [1] swh/infra/sysadm-environment#3438 (closed)

Related to #3358 (closed)

---

Migrated from D6010 (view on Phabricator)

swh/lister/opam/lister.py

@@ -51,9 +51,19 @@ class OpamLister(StatelessLister[PageType]):
             scheduler=scheduler, credentials=credentials, url=url, instance=instance,
         )
         self.env = os.environ.copy()
-        self.env["OPAMROOT"] = tempfile.mkdtemp(prefix="swh_opam_lister")
+        self.opamroot = tempfile.mkdtemp(prefix="swh_opam_lister")
         call(
-            ["opam", "init", "--reinit", "--bare", "--no-setup", instance, url],
+            [
+                "opam",
+                "init",
+                "--reinit",
+                "--bare",
+                "--no-setup",
+                "--root",
+                self.opamroot,
+                instance,
+                url,
+            ],
             env=self.env,
         )
 
@@ -66,6 +76,8 @@ class OpamLister(StatelessLister[PageType]):
                 "--no-switch",
                 "--repos",
                 self.instance,
+                "--root",
+                self.opamroot,
                 "--normalise",
                 "--short",
             ],
@@ -87,7 +99,7 @@ class OpamLister(StatelessLister[PageType]):
             url=url,
             last_update=None,
             extra_loader_arguments={
-                "opam_root": self.env["OPAMROOT"],
+                "opam_root": self.opamroot,
                 "opam_instance": self.instance,
                 "opam_url": self.url,
                 "opam_package": page,