Skip to content

swh-lister: Remove deprecated console scripts `swh-lister`

Antoine R. Dumont requested to merge generated-differential-D2014-source into generated-differential-D2014-target

Prior to this commit, the pip activation environment failed because the old cli cli name got renamed to lister. It was fixed for the subcommand, not for the command.

Avoid too much maintenance hassle, droping it.

Test Plan

  1. Play with virtualenv:
$ workon swh
Traceback (most recent call last):
  File "/home/tony/.virtualenvs/swh/lib/python3.7/site-packages/pkg_resources/__init__.py", line 2442, in resolve
    return functools.reduce(getattr, self.attrs, module)
AttributeError: module 'swh.lister.cli' has no attribute 'cli'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/tony/.virtualenvs/swh/bin/swh-lister", line 11, in <module>
    load_entry_point('swh.lister', 'console_scripts', 'swh-lister')()
  File "/home/tony/.virtualenvs/swh/lib/python3.7/site-packages/pkg_resources/__init__.py", line 489, in load_entry_point
    return get_distribution(dist).load_entry_point(group, name)
  File "/home/tony/.virtualenvs/swh/lib/python3.7/site-packages/pkg_resources/__init__.py", line 2843, in load_entry_point
    return ep.load()
  File "/home/tony/.virtualenvs/swh/lib/python3.7/site-packages/pkg_resources/__init__.py", line 2434, in load
    return self.resolve()
  File "/home/tony/.virtualenvs/swh/lib/python3.7/site-packages/pkg_resources/__init__.py", line 2444, in resolve
    raise ImportError(str(exc))
ImportError: module 'swh.lister.cli' has no attribute 'cli'
$ # Fix by patching this diff
$ deactivate  # from within swh-env's virtualenv (or some such)
$ workon swh  # <- no more warning
$ which swh-lister
/home/tony/.virtualenvs/swh/bin/swh-lister  # \m/
  1. tox is still happy
tox

Migrated from D2014 (view on Phabricator)

Merge request reports