revision metadata indexer: Fix multiple errors

This diffs fixes quite some initialization issues and other errors (variable initialization, logging format exception) in the revision metadata indexer.

Note for later. We need to simplify the initialization of the indexers. This has become far too tedious in its current state.

For this, I think we could:

• remove the prepare() indirection
• and use bare init (which is more pythonic and expected)
• to override the configuration in tests, override the parse_config_file (coming from the SWHConfig instead of overriding prepare)

Test Plan

tox

---

Migrated from D712 (view on Phabricator)

swh/indexer/tests/test_metadata.py

@@ -39,12 +39,9 @@ class RevisionMetadataTestIndexer(RevisionMetadataIndexer):
 
     def prepare(self):
         self.config = {
-            'storage': {
-                'cls': 'remote',
-                'args': {
-                    'url': 'http://localhost:9999',
-                }
-            },
+            'storage': {},
+            'objstorage': {},
+            'indexer_storage': {},
             'tools': {
                 'name': 'swh-metadata-detector',
                 'version': '0.0.2',
@@ -60,7 +57,6 @@ class RevisionMetadataTestIndexer(RevisionMetadataIndexer):
         self.objstorage = MockObjStorage()
         self.tools = self.register_tools(self.config['tools'])
         self.tool = self.tools[0]
-        self.results = []
 
 
 class Metadata(unittest.TestCase):