Skip to content
Snippets Groups Projects

github: Add support for 'topics'


Migrated from D8416 (view on Phabricator)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Build is green

    Patch application report for D8416 (id=30362)

    Could not rebase; Attempt merge onto 44879ab5...

    Updating 44879ab..dd02741
    Fast-forward
     swh/indexer/metadata.py                            | 34 +++++++++++++++-------
     swh/indexer/metadata_dictionary/github.py          |  6 +++-
     .../tests/metadata_dictionary/test_github.py       | 20 +++++++++++--
     swh/indexer/tests/test_metadata.py                 | 29 ++++++++++++++++++
     4 files changed, 75 insertions(+), 14 deletions(-)
    Changes applied before test
    commit dd0274193f5228ded709fb150c1685ddaafeed73
    Author: Valentin Lorentz <vlorentz@softwareheritage.org>
    Date:   Thu Sep 8 11:12:56 2022 +0200
    
        github: Add support for 'topics'
    
    commit befdbd7efd46dd052b8728215deeeb3f775c34d0
    Author: Valentin Lorentz <vlorentz@softwareheritage.org>
    Date:   Mon Sep 5 15:48:40 2022 +0200
    
        Fix crash when RawExtrinsicMetadata target new origins
        
        RawExtrinsicMetadata contain a swh:1:ori: identifier of the origin,
        which the indexer needs to resolve, by querying its storage replica.
        
        Because RawExtrinsicMetadata are created by loaders, they are often
        created shortly after the origin is created by the corresponding lister,
        so the origin may not be known to the storage replica used by the
        indexer, causing this function to crash.
        
        Waiting 10s seems to be good enough when run on my computer with
        production data and moma's replica; so I set it to 60s just to be safe.
    
    commit 68940cfccfed258620cc116bedd6598fd9b28df4
    Author: Valentin Lorentz <vlorentz@softwareheritage.org>
    Date:   Mon Sep 5 14:21:50 2022 +0200
    
        Fix crash when RawExtrinsicMetadata objects have the same target
        
        ... and they are processed in the same batch.
        
        The last one received takes precedence, as it is likely to be more
        up-to-date

    See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/482/ for more details.

  • Merge request was accepted

  • Antoine R. Dumont approved this merge request

    approved this merge request

  • Author Maintainer

    Merge request was merged

  • closed

Please register or sign in to reply
Loading