Include Sentry context tags even when capture_exceptions=False

When capture_exceptions=False, the indexer's caller reports the exception to Sentry itself.

However, because tags were added by indexers within a scope internal to the indexers; the scope was closed before returning to the caller, so these tags were actually not sent to Sentry.

---

Migrated from D8216 (view on Phabricator)

Build was aborted

Patch application report for D8216 (id=29630)

Rebasing onto e29700bd...

Current branch diff-target is up to date.

Changes applied before test

commit 5313be86b3fa1da858592591a2fd51406ce78cf6
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Aug 8 15:40:55 2022 +0200

    Include Sentry context tags even when capture_exceptions=False
    
    When capture_exceptions=False, the indexer's caller reports the exception
    to Sentry itself.
    
    However, because tags were added by indexers within a scope internal
    to the indexers; the scope was closed before returning to the caller,
    so these tags were actually not sent to Sentry.

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/411/ See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/411/console

Build is green

Patch application report for D8216 (id=29630)

Rebasing onto e29700bd...

Current branch diff-target is up to date.

Changes applied before test

commit 5313be86b3fa1da858592591a2fd51406ce78cf6
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Aug 8 15:40:55 2022 +0200

    Include Sentry context tags even when capture_exceptions=False
    
    When capture_exceptions=False, the indexer's caller reports the exception
    to Sentry itself.
    
    However, because tags were added by indexers within a scope internal
    to the indexers; the scope was closed before returning to the caller,
    so these tags were actually not sent to Sentry.

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/412/ for more details.

Looks good to me, too bad we cannot use sentry scopes due to this limitation.

Merge request was accepted

approved this merge request

Merge request was merged

closed