Make BaseIndexer.catch_exception=False actually re-raise exceptions instead of silencing them.

Since eed35313, the 'finally' clause silenced re-raised exception because it contains a 'return' statement.

---

Migrated from D4151 (view on Phabricator)