Skip to content
Snippets Groups Projects

Return a list of persons for author and committer fields

2 unresolved threads

Author and committer in revision and author in release are now returning a single person object. Change that to a list of persons to support multiple authors in the data model.


Migrated from D8986 (view on Phabricator)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
2 2 # See the AUTHORS file at the top-level directory of this distribution
3 3 # License: GNU General Public License version 3, or any later version
4 4 # See top-level LICENSE file for more information
5
6 from typing import List
7
8 from .base_connection import BaseList
9 from .base_node import BaseNode
10 from .release import BaseReleaseNode
11 from .revision import BaseRevisionNode
12
13
14 class Person(BaseNode):
15 pass
16
17
  • vlorentz
    vlorentz @vlorentz started a thread on the diff
  • 14 class Person(BaseNode):
    15 pass
    16
    17
    18 def get_person_list(person) -> List[Person]:
    19 return [person] if person else []
    20
    21
    22 class RevisionAuthorList(BaseList):
    23 """
    24 List of revision authors
    25 """
    26
    27 obj: BaseRevisionNode
    28
    29 _node_class = Person
  • Merge request was accepted

  • vlorentz approved this merge request

    approved this merge request

  • Author Contributor

    improve trye hints

  • Build has FAILED

    Patch application report for D8986 (id=32378)

    Rebasing onto f6b5a2d5...

    Current branch diff-target is up to date.
    Changes applied before test
    commit 908921fc7467f720454e1734f2132309012d48d9
    Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
    Date:   Mon Dec 26 11:19:13 2022 +0100
    
        Return a list of persons for author and committer fields
        
        Author and committer in revision and author in release are now
        returning a single person object. Change that to a list
        of persons to support multiple authors in the data model.

    Link to build: https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/278/ See console output for more information: https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/278/console

  • Author Contributor

    mypy fix

  • Build is green

    Patch application report for D8986 (id=32379)

    Rebasing onto f6b5a2d5...

    Current branch diff-target is up to date.
    Changes applied before test
    commit 413b4c733c2804ec0e2f97ce85ac0281f4f43f76
    Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
    Date:   Mon Dec 26 11:19:13 2022 +0100
    
        Return a list of persons for author and committer fields
        
        Author and committer in revision and author in release are now
        returning a single person object. Change that to a list
        of persons to support multiple authors in the data model.

    See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/279/ for more details.

  • Author Contributor

    Merge request was merged

  • closed

  • Please register or sign in to reply
    Loading