Skip to content

REST server: support HEAD requests

Stefano Zacchiroli requested to merge generated-differential-D2247-source into generated-differential-D2247-target

Current implementation of the REST server only supports GET requests, supporting HEAD requests would be nice too. This diff is the key ingredient, but it's not enough yet. In particular, HEAD requests on routes that use get_simple_traversal_handler, visit_paths, and walk make the server side explode with tracebacks when the web app tries to write the response body.

We should change it to not try to write body if the request is HEAD, but I'm not sure what's the most elegant way to do so in aiohttp. There is built-in support for that to some extent (see: https://github.com/aio-libs/aiohttp/pull/838 ), but it's not working out of the box with the above methods.

I'm also pushing this to branch feature/http-head-reqs

Migrated from D2247 (view on Phabricator)

Merge request reports