Skip to content

Reorganize configuration of the http server building

David Douard requested to merge generated-differential-D8448-source into generated-differential-D8448-target

rework the configuration for swh.graph.http_server.make_app() so that one can start the http server usig an existing grpc server by a setting the configuration file accordingly.

This make the make_app() function only accept one config structure (dict), which structure would be:

graph: cls: local grpc_server: # config for spawn_java_grpc_server() ... rpc_server: # config for GraphServerApp() ...

or:

graph: cls: remote url: # host:port of the running grpc server ... rpc_server: # config for GraphServerApp() ...

This also comes wit a few other refactorings:

  • rename swh/graph/rpc/ as swh/graph/grpc/ to prevent confusion with the (http) rpc server.
  • similarly, rename swh/graph/rpc_server.py as swh/graph/grpc_server.py
  • remove the "graph" config section from the grpc_server config structure (it had only the "path" config entry).

Depends on !133 (closed)

Migrated from D8448 (view on Phabricator)

Merge request reports