Skip to content
Snippets Groups Projects
Aymeric Varasse's avatar
approved merge request !139 "Add support for resuming from interrupted export" at Platform / Development / swh-export
Aymeric Varasse's avatar
commented on merge request !139 "Add support for resuming from interrupted export" at Platform / Development / swh-export

LGTM (aside from the YAML thing)

Aymeric Varasse's avatar
approved merge request !141 "Fix hanging in exports with no persons" at Platform / Development / swh-export
Aymeric Varasse's avatar
commented on merge request !141 "Fix hanging in exports with no persons" at Platform / Development / swh-export

LGTM (once rebased) 👍

Aymeric Varasse's avatar
commented on merge request !139 "Add support for resuming from interrupted export" at Platform / Development / swh-export

This should be a YAML file

Aymeric Varasse's avatar
commented on merge request !139 "Add support for resuming from interrupted export" at Platform / Development / swh-export

Ok, that makes sense to me

Jenkins Bot's avatar
commented on merge request !139 "Add support for resuming from interrupted export" at Platform / Development / swh-export

Jenkins job swh-export/gitlab-builds #77 succeeded in 1 min 13 sec.See Console Output, Blue Ocean and Coverage Report for more details.

vlorentz's avatar
vlorentz's avatar
commented on merge request !139 "Add support for resuming from interrupted export" at Platform / Development / swh-export

oops

vlorentz's avatar
commented on merge request !139 "Add support for resuming from interrupted export" at Platform / Development / swh-export

multiple instances of ExportTopic could run at the same time, and I don't know how mkdir behaves when this happens

Jenkins Bot's avatar
commented on merge request !141 "Fix hanging in exports with no persons" at Platform / Development / swh-export

Jenkins job swh-export/gitlab-builds #76 failed in 54 sec.See Console Output, Blue Ocean and Coverage Report for more details.

Jenkins Bot's avatar
commented on merge request !139 "Add support for resuming from interrupted export" at Platform / Development / swh-export

Jenkins job swh-export/gitlab-builds #74 succeeded in 1 min 17 sec.See Console Output, Blue Ocean and Coverage Report for more details.

vlorentz's avatar
opened merge request !141 "Fix hanging in exports with no persons" at Platform / Development / swh-export
vlorentz's avatar
vlorentz's avatar
  • 55611ae6 · Fix bugs and make the CLI resume on error too
Aymeric Varasse's avatar
commented on merge request !139 "Add support for resuming from interrupted export" at Platform / Development / swh-export

Maybe a dumb question, but is f still in context here?

Aymeric Varasse's avatar
commented on merge request !139 "Add support for resuming from interrupted export" at Platform / Development / swh-export

Why do we need to do this here? Can't it be done at the beggining of the ExportTopic task?

Jenkins Bot's avatar
commented on merge request !139 "Add support for resuming from interrupted export" at Platform / Development / swh-export

Jenkins job swh-export/gitlab-builds #73 succeeded in 1 min 13 sec.See Console Output, Blue Ocean and Coverage Report for more details.

vlorentz's avatar
vlorentz's avatar
commented on merge request !138 "Require the swh.journal pytest plugin explicitly" at Platform / Development / swh-export

oh sorry, I missed this MR when writing !140 (merged)