deposit_read: Simplify api to return only relevant deposit information

With this, the deposit information needed for the deposit loader to build the revision are sent in the "deposit" key. It contains the following keys:

• id: Deposit id
• collection: collection name
• client: client name
• author_date: creation date
• author: author
• committer_date: publisher date
• committer: publisher

This avoids:

• unnecessary redundancy. Metadata were set in multiple places even though identical.
• some information were no longer used (branch name, synthetic, revision type, etc...)

Test Plan

tox

---

Migrated from D3047 (view on Phabricator)

swh/deposit/api/private/deposit_read.py

@@ -174,50 +174,37 @@ class SWHDepositReadMetadata(SWHPrivateAPIView, SWHGetDepositAPI, DepositReadMix
         # Read information metadata
         data = {"origin": {"type": "deposit", "url": deposit.origin_url,}}
 
-        # revision
-
-        fullname = deposit.client.username
-        author_committer = SWH_PERSON
-
         # metadata provider
         self.provider["provider_name"] = deposit.client.last_name
         self.provider["provider_url"] = deposit.client.provider_url
 
-        revision_type = "tar"
-        revision_msg = "%s: Deposit %s in collection %s" % (
-            fullname,
-            deposit.id,
-            deposit.collection.name,
-        )
-
         author_date, commit_date = self._normalize_dates(deposit, metadata)
 
-        data["revision"] = {
-            "synthetic": True,
-            "date": author_date,
-            "committer_date": commit_date,
-            "author": author_committer,
-            "committer": author_committer,
-            "type": revision_type,
-            "message": revision_msg,
-            "metadata": metadata,
-        }
-
         if deposit.parent:
             swh_persistent_id = deposit.parent.swh_id
             persistent_identifier = identifiers.parse_persistent_identifier(
                 swh_persistent_id
             )
             parent_revision = persistent_identifier.object_id
+            parents = [parent_revision]
+        else:
+            parents = []
 
-            data["revision"]["parents"] = [parent_revision]
-
-        data["branch_name"] = "master"
         data["origin_metadata"] = {
             "provider": self.provider,
             "tool": self.tool,
             "metadata": metadata,
         }
+        data["deposit"] = {
+            "id": deposit.id,
+            "client": deposit.client.username,
+            "collection": deposit.collection.name,
+            "author": SWH_PERSON,
+            "author_date": author_date,
+            "committer": SWH_PERSON,
+            "committer_date": commit_date,
+            "revision_parents": parents,
+        }
 
         return data