Skip to content
Snippets Groups Projects

Rewrite blueprint flowcharts using Plantuml instead of .png files.

Closed Rewrite blueprint flowcharts using Plantuml instead of .png files.
generated-differential-D4248-source into generated-differential-D4248-target
3 unresolved threads
Closed vlorentz requested to merge generated-differential-D4248-source into generated-differential-D4248-target
3 unresolved threads

There are a few mistakes, but they were already in the original files; a future commit will fix them.

deposit-create-chart.svg

deposit-update-chart.svg

deposit-delete-chart.svg

Related to T2618

Migrated from D4248 (view on Phabricator)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
docs/images/deposit-create-chart.uml 0 → 100644
11
12 DEPOSIT ->> DEPOSIT_STORAGE: check authentication
13 DEPOSIT_STORAGE -->> DEPOSIT: return ok (if client exists and credentials ok)
14
15 DEPOSIT -->> CLIENT: return 200, <service-document>
16
17 CLIENT ->> DEPOSIT: POST /1/<collection-name>/
18
19 DEPOSIT ->> DEPOSIT_STORAGE: check authentication
20 DEPOSIT_STORAGE -->> DEPOSIT: return ok (if client exists and credentials ok)
21
22 DEPOSIT ->> DEPOSIT_STORAGE: create new deposit
23 DEPOSIT_STORAGE -->> DEPOSIT: return deposit_id
24
25 DEPOSIT -->> CLIENT: return 201, <deposit receipt>
26 @enduml
  • Antoine R. Dumont
    Antoine R. Dumont @ardumont started a thread on the diff
    • docs/images/deposit-update-chart.uml 0 → 100644
    15 DEPOSIT -->> CLIENT: return 201, <deposit receipt>
    16
    17 loop while status is 'partial'
    18
    19 CLIENT -> DEPOSIT: POST/PUT /1/<collection-name>/<deposit-id>/media/\nPOST/PUT /1/<collection-name>/<deposit-id>/metadata/
    20
    21 DEPOSIT ->> DEPOSIT_STORAGE: check authentication
    22 DEPOSIT_STORAGE -->> DEPOSIT: return ok
    23
    24 DEPOSIT ->> DEPOSIT_STORAGE: check inputs()
    25 DEPOSIT_STORAGE -->> DEPOSIT: return ok
    26
    27 alt HEADER: In-Progress = true
    28 DEPOSIT ->> DEPOSIT_STORAGE: add-or-replace-data-and-update-status('partial')
    29 else HEADER: In-Progress = false
    30 DEPOSIT ->> DEPOSIT_STORAGE: add-or-replace-data-and-update-status('ready')
  • Antoine R. Dumont
    Antoine R. Dumont @ardumont started a thread on the diff
    • docs/specs/blueprint.rst
    43 .. figure:: ../images/deposit-create-chart.png
    41 .. figure:: ../images/deposit-create-chart.svg
    44 42 :alt:
    45 43
    46 44
    45 Deposit statuses:
    46
    47 'partial'
    48 The deposit is new or partially received, since it can be done in
    49 multiple requests
    50
    51 'expired'
    52 Deposit was there too long and is new deemed ready to be
    53 garbage-collected
    54
    55 'ready'
  • Antoine R. Dumont
    Antoine R. Dumont @ardumont ·
    Maintainer

    Thanks a lot for this.

    I see things can be improved again but that's not really the subject of the diff (subject is technical rewrite ;). In the mean time, let's land it.

    I can take care of the adaptations when this lands. (if you want).

    Cheers,

  • Antoine R. Dumont
    Antoine R. Dumont @ardumont ·
    Maintainer

    Merge request was accepted

  • Antoine R. Dumont approved this merge request

    approved this merge request

  • vlorentz
    vlorentz @vlorentz ·
    Author Maintainer

    Merge request was merged

  • vlorentz closed

    closed

    • Please register or sign in to reply