Rename metadata_raw to raw_metadata in the private API
Closed
requested to merge generated-differential-D7522-source into generated-differential-D7522-target
'metadata_raw' made sense, to discriminate from 'metadata_dict'; but no longer does, now that the latter was removed.
Additionally, swh-web expects it to be named 'raw_metadata', so it could never actually get the metadata.
Migrated from D7522 (view on Phabricator)
Merge request reports
Activity
mentioned in merge request swh-loader-core!279 (closed)
Build has FAILED
Patch application report for D7522 (id=27289)
Rebasing onto 6d1089cb...
Current branch diff-target is up to date.
Changes applied before test
commit 4415b647ac1f3ff4f16e4fd338f60272a0418ebc Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Thu Apr 7 14:34:25 2022 +0200 Rename metadata_raw to raw_metadata in the private API 'metadata_raw' made sense, to discriminate from 'metadata_dict'; but no longer does, now that the latter was removed. Additionally, swh-web expects it to be named 'raw_metadata', so it could never actually get the metadata.
Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/830/ See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/830/console
Build is green
Patch application report for D7522 (id=27290)
Rebasing onto 6d1089cb...
Current branch diff-target is up to date.
Changes applied before test
commit 56da78d0bf3b6f45ced055d7df644542e471299c Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Thu Apr 7 14:34:25 2022 +0200 Rename metadata_raw to raw_metadata in the private API 'metadata_raw' made sense, to discriminate from 'metadata_dict'; but no longer does, now that the latter was removed. Additionally, swh-web expects it to be named 'raw_metadata', so it could never actually get the metadata.
See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/831/ for more details.
mentioned in issue swh/meta#3939
Please register or sign in to reply