Skip to content
Snippets Groups Projects

spec-technical: Add 'partial' self-loop + annotate transitions in the status diagram

Closed spec-technical: Add 'partial' self-loop + annotate transitions in the status diagram
generated-differential-D4283-source into generated-differential-D4283-target
2 unresolved threads
Closed vlorentz requested to merge generated-differential-D4283-source into generated-differential-D4283-target
2 unresolved threads

status.svg

Depends on !120 (closed)

Migrated from D4283 (view on Phabricator)

Merge request reports

Approved by
Antoine R. Dumont

Closed by Phabricator Migration userPhabricator Migration user 4 years ago (Oct 16, 2020 4:21pm UTC)

Merge details

  • The changes were not merged into generated-differential-D4283-target.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Software Heritage Continuous Integration for public repositories
    Software Heritage Continuous Integration for public repositories @swh-public-ci ·

    Build is green

    Patch application report for D4283 (id=15141)

    Could not rebase; Attempt merge onto 7e05dbe4...

    Updating 7e05dbe4..7cc8d329
Fast-forward
 docs/images/status.png        | Bin 9825 -> 0 bytes
 docs/images/status.uml        |  27 +++++++++++++++++++++++++++
 docs/specs/spec-technical.rst |   6 +-----
 3 files changed, 28 insertions(+), 5 deletions(-)
 delete mode 100644 docs/images/status.png
 create mode 100644 docs/images/status.uml
    Changes applied before test
    commit 7cc8d3299e37c0c9fc916b31ab96931b48f7a6bc
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Oct 16 11:00:49 2020 +0200

    spec-technical: Add 'partial' self-loop + annotate transitions in the status diagram

commit efda75628fb1ac9330779259ecd244717596c0a9
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Oct 16 10:38:49 2020 +0200

    spec-technical: Rewrite state diagram using Plantuml.

    See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/266/ for more details.

  • Antoine R. Dumont
    Antoine R. Dumont @ardumont started a thread on the diff
docs/images/status.uml
1 1 @startuml
2 [*] --> partial
3 partial --> deposited
2 hide empty description
3
4 state request <<choice>>
5
6 [*] --> request : POST Col-IRI
7
8 request --> deposited : [ without In-Progress: true ]
  • Antoine R. Dumont
    Antoine R. Dumont @ardumont started a thread on the diff
    • docs/images/status.uml
    1 1 @startuml
    2 [*] --> partial
    3 partial --> deposited
    2 hide empty description
    3
    4 state request <<choice>>
    5
    6 [*] --> request : POST Col-IRI
    7
    8 request --> deposited : [ without In-Progress: true ]
    9 request --> partial : [ with In-Progress: true ]
    10
    11 partial --> request : PUT EM-IRI
  • Antoine R. Dumont
    Antoine R. Dumont @ardumont ·
    Maintainer

    Nice.

  • Antoine R. Dumont
    Antoine R. Dumont @ardumont ·
    Maintainer

    Merge request was returned for changes

  • Antoine R. Dumont
    Antoine R. Dumont @ardumont ·
    Maintainer

    Thanks.

    You can add the other endpoints in another diff if you want ;)

    Cheers,

  • Antoine R. Dumont
    Antoine R. Dumont @ardumont ·
    Maintainer

    Merge request was accepted

  • Antoine R. Dumont approved this merge request

    approved this merge request

  • vlorentz
    vlorentz @vlorentz ·
    Author Maintainer

    Merge request was merged

  • vlorentz closed

    closed

    • Please register or sign in to reply