Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • S swh-deposit
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 54
    • Issues 54
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Platform
  • Development
  • swh-deposit
  • Issues
  • #3094
Closed
Open
Issue created Mar 05, 2021 by Antoine R. Dumont@ardumontMaintainer

deposit: Internal deposit api should send the "archive.tar" name to the deposit loader

Currently the deposit loader reads the deposit artifacts from the deposit server via an internal api. That api streams the archive to the loader without naming it. Forcing the deposit loader to hard-code a name (currently configured through a "default_filename" constructor attribute in the loader).

This is currently consistent so no harm done.

A more suitable approach would be to make the deposit server api send the archive name alongside the streamed archive (through http header for example).

That changes would need a second change in the deposit loader as well so that the loader reads such information to name the retrieved archive appropriately (and then drop the "default_filename" from the loader constructor).


Migrated from T3094 (view on Phabricator)

Assignee
Assign to
Time tracking