swh.deposit.api.private: Fix revision message missing client name

swh/deposit/api/private/deposit_read.py

@@ -184,7 +184,7 @@ class SWHDepositReadMetadata(SWHGetDepositAPI, SWHPrivateAPIView):
 
         # revision
 
-        fullname = deposit.client.get_full_name()
+        fullname = deposit.client.username
         author_committer = SWH_PERSON
 
         # metadata provider

swh/deposit/tests/api/test_deposit_read_metadata.py

@@ -58,7 +58,7 @@ class DepositReadMetadataTest(APITestCase, WithAuthTestCase, BasicTestCase,
                         'some-external-id'
                 },
                 'provider': {
-                    'provider_name': '',
+                    'provider_name': 'hal',
                     'provider_type': 'deposit_client',
                     'provider_url': 'https://hal-test.archives-ouvertes.fr/',
                     'metadata': {}
@@ -74,7 +74,7 @@ class DepositReadMetadataTest(APITestCase, WithAuthTestCase, BasicTestCase,
             'revision': {
                 'synthetic': True,
                 'committer_date': None,
-                'message': ': Deposit %s in collection hal' % deposit_id,
+                'message': 'hal: Deposit %s in collection hal' % deposit_id,
                 'author': SWH_PERSON,
                 'committer': SWH_PERSON,
                 'date': None,
@@ -146,7 +146,7 @@ class DepositReadMetadataTest(APITestCase, WithAuthTestCase, BasicTestCase,
                         'some-external-id'
                 },
                 'provider': {
-                    'provider_name': '',
+                    'provider_name': 'hal',
                     'provider_type': 'deposit_client',
                     'provider_url': 'https://hal-test.archives-ouvertes.fr/',
                     'metadata': {}
@@ -166,7 +166,7 @@ class DepositReadMetadataTest(APITestCase, WithAuthTestCase, BasicTestCase,
                 'author': SWH_PERSON,
                 'committer': SWH_PERSON,
                 'type': 'tar',
-                'message': ': Deposit %s in collection hal' % deposit_id,
+                'message': 'hal: Deposit %s in collection hal' % deposit_id,
                 'metadata': {
                     '{http://www.w3.org/2005/Atom}external_identifier':
                     'some-external-id',

swh/deposit/tests/common.py

@@ -198,6 +198,7 @@ class BasicTestCase(TestCase):
                                                     provider_url=_provider_url,
                                                     domain=_domain)
         _client.collections = [_collection.id]
+        _client.last_name = _name
         _client.save()
 
         self.collection = _collection