Skip to content
Snippets Groups Projects

api/RPCClient: Do not raise 404 remote exception if it must be reraised

The RPCClient class has a reraise_exceptions list containing exception types that should be reraised client side instead of wrapping them in a RemoteException instance.

If the remote exception comes with a 404 HTTP status code, it was automatically raised as a RemoteException regardless if the exception type must be reraised client side.

So ensure to not raise a RemoteException if the 404 remote exception should be reraised.

That change is required to fix HTTP status code for missing objects when querying the swh-objstorage RPC endpoints (aka 404, see D8228).


Migrated from D8227 (view on Phabricator)

Merge request reports

Closed by Phabricator Migration userPhabricator Migration user 2 years ago (Aug 10, 2022 3:11pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading