cli.db: Use attribute current_version instead of undeclared getter

I have no idea why both exist. But this centralized one (current_version) is declared on most swh modules vs the other method which is not [2]

• [1]

$SWH_ENVIRONMENT_HOME/swh-indexer/swh/indexer/storage/db.py:    current_version = 133
$SWH_ENVIRONMENT_HOME/swh-scheduler/swh/scheduler/backend.py:    current_version = 33
$SWH_ENVIRONMENT_HOME/swh-scrubber/swh/scrubber/db.py:    current_version = 2
$SWH_ENVIRONMENT_HOME/swh-storage/swh/storage/postgresql/db.py:    current_version = 182
$SWH_ENVIRONMENT_HOME/swh-vault/swh/vault/backend.py:    current_version = 4

• [2]

grep -r "get_current_version(" $SWH_ENVIRONMENT_HOME/*/swh/
$SWH_ENVIRONMENT_HOME/swh-indexer/swh/indexer/storage/__init__.py:    def get_current_version(self, *, db=None, cur=None):
$SWH_ENVIRONMENT_HOME/swh-scheduler/swh/scheduler/backend.py:    def get_current_version(self):
$SWH_ENVIRONMENT_HOME/swh-storage/swh/storage/postgresql/storage.py:    def get_current_version(self, *, db: Db, cur=None):

Related to T4284 Supersedes !276 (closed)

Test Plan

Patched on scrubber0.staging and now the cli works! [1]

• [1]

swhworker@scrubber0:~$ swh db --config-file config.yml version scrubber
module: scrubber
current code version: 2
version: 1

---

Migrated from D7907 (view on Phabricator)

swh/core/cli/db.py

@@ -198,16 +198,14 @@ def db_init(ctx, module, dbname, flavor, initial_version):
             datastore_factory = getattr(import_swhmodule(module), "get_datastore", None)
             if datastore_factory:
                 datastore = datastore_factory(**cfg)
-                try:
-                    get_current_version = datastore.get_current_version
-                except AttributeError:
+                if not hasattr(datastore, "current_version"):
                     logger.warning(
-                        "Datastore %s does not implement the "
-                        "'get_current_version()' method",
+                        "Datastore %s does not declare the "
+                        "'current_version' attribute",
                         datastore,
                     )
                 else:
-                    code_version = get_current_version()
+                    code_version = datastore.current_version
                     logger.info(
                         "Initializing database version to %s from the %s datastore",
                         code_version,
@@ -299,7 +297,7 @@ def db_version(ctx, module, show_all):
     datastore_factory = getattr(import_swhmodule(db_module), "get_datastore", None)
     if datastore_factory:
         datastore = datastore_factory(**cfg)
-        code_version = datastore.get_current_version()
+        code_version = datastore.current_version
         click.secho(
             f"current code version: {code_version}",
             fg="green" if code_version == db_version else "red",
@@ -387,7 +385,7 @@ def db_upgrade(ctx, module, to_version, interactive):
             "You cannot use this command on old-style datastore backend {db_module}"
         )
     datastore = datastore_factory(**cfg)
-    ds_version = datastore.get_current_version()
+    ds_version = datastore.current_version
     if to_version is None:
         to_version = ds_version
     if to_version > ds_version: