deprecate the db/pytest_plugin.py module

this diff consist in 4 revisions:

• tests: use stock pytest_postgresql factory function instead of the custom factory_fact.

• mark postgresql_fact fixture factory function as deprecated

• move initialize_database_for_module in db_utils to prepare the deprecation of db/pytest_plugin.py; it's the only function from db/pytest_plugin.py still in use.

• deprecate the module entirely.

Closes #4285 (closed).

---

Migrated from D7934 (view on Phabricator)

swh/core/db/tests/test_db.py

@@ -16,11 +16,11 @@ from hypothesis import given, settings, strategies
 from hypothesis.extra.pytz import timezones
 import psycopg2
 import pytest
+from pytest_postgresql import factories
 from typing_extensions import Protocol
 
 from swh.core.db import BaseDb
 from swh.core.db.common import db_transaction, db_transaction_generator
-from swh.core.db.pytest_plugin import postgresql_fact
 from swh.core.db.tests.conftest import function_scoped_fixture_check
 
 
@@ -244,7 +244,7 @@ def convert_lines(cur):
     ]
 
 
-test_db = postgresql_fact("postgresql_proc", dbname="test-db2")
+test_db = factories.postgresql("postgresql_proc", dbname="test-db2")
 
 
 @pytest.fixture