pytest_plugins: Make postgresql_fact accept List[str] in addition to str.
in swh-storage!640, swh.storage will need it to specify explicitly migration files to run.
Migrated from D5016 (view on Phabricator)
Merge request reports
Activity
Build is green
Patch application report for D5016 (id=17887)
Rebasing onto 76d2a003...
Current branch diff-target is up to date.
Changes applied before test
commit 793c5f5ba3a2375601b9c63de708d4692e5eebcc Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Thu Feb 4 14:43:56 2021 +0100 pytest_plugins: Make postgresql_fact accept List[str] in addition to str. swh.storage will need it to specify explicitly migration files to run.
See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/192/ for more details.
36 36 port: str, 37 37 db_name: str, 38 38 version: Union[str, float, Version], 39 dump_files: Optional[str] = None, 39 dump_files: Union[None, str, List[str]] = None, 40 40 no_truncate_tables: Set[str] = set(), 41 41 ) -> None: 42 42 super().__init__(user, host, port, db_name, version) 43 if dump_files: 43 if dump_files is None: 44 self.dump_files = [] 45 elif isinstance(dump_files, str): 44 46 self.dump_files = sorted(glob.glob(dump_files), key=sortkey) 45 47 else: 46 self.dump_files = [] 48 self.dump_files = dump_files Fine with the idea.
Missing tests though.
Use existing tests [1] to add some equivalent tests with a fixture initialized with the new way you opened here for example.
Build has FAILED
Patch application report for D5016 (id=17964)
Rebasing onto 76d2a003...
Current branch diff-target is up to date.
Changes applied before test
commit b37cd9a8d787cc192873143c674d590ae5797cde Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Thu Feb 4 14:43:56 2021 +0100 pytest_plugins: Make postgresql_fact accept List[str] in addition to str. swh.storage will need it to specify explicitly migration files to run.
Link to build: https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/193/ See console output for more information: https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/193/console
Build has FAILED
Patch application report for D5016 (id=17964)
Rebasing onto 76d2a003...
Current branch diff-target is up to date.
Changes applied before test
commit b37cd9a8d787cc192873143c674d590ae5797cde Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Thu Feb 4 14:43:56 2021 +0100 pytest_plugins: Make postgresql_fact accept List[str] in addition to str. swh.storage will need it to specify explicitly migration files to run.
Link to build: https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/196/ See console output for more information: https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/196/console
Build is green
Patch application report for D5016 (id=18136)
Rebasing onto 76d2a003...
Current branch diff-target is up to date.
Changes applied before test
commit 576b1047998d876a16464606b78454036afa8dfc Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Thu Feb 4 14:43:56 2021 +0100 pytest_plugins: Make postgresql_fact accept List[str] in addition to str. swh.storage will need it to specify explicitly migration files to run.
See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/197/ for more details.