core tests: disambiguate arg 'request' through typing

Both requests.Request and _pytest.FixtureRequest objects are passed to test fixtures as argument 'request'. This hurts readability. Adding typing annotations makes it clear which one is meant.

---

Migrated from D4382 (view on Phabricator)

Build is green

Patch application report for D4382 (id=15494)

Rebasing onto eefe1b63...

Current branch diff-target is up to date.

Changes applied before test

commit 0005aebe550caf2d853912f6343970cf627bb3a8
Author: tenma <tenma+swh@mailbox.org>
Date:   Thu Oct 29 14:43:52 2020 +0100

    tests: disambiguate arg 'request' through typing
    
    Both requests.Request and _pytest.FixtureRequest objects are passed to
    test fixtures as argument 'request'. This hurts readability.
    Adding typing annotations makes it clear which one is meant.

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/125/ for more details.

Merge request was accepted

approved this merge request

Removed comment

Build is green

Patch application report for D4382 (id=15503)

Rebasing onto 74544839...

First, rewinding head to replay your work on top of it...
Applying: core tests: disambiguate arg 'request' through typing

Changes applied before test

commit f66c70622ca0294d5d6413196b7f55406223cc8b
Author: tenma <tenma+swh@mailbox.org>
Date:   Thu Oct 29 14:43:52 2020 +0100

    core tests: disambiguate arg 'request' through typing
    
    Both requests.Request and _pytest.FixtureRequest objects are passed to
    test fixtures as argument 'request'. This hurts readability.
    Adding typing annotations makes it clear which one is meant.

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/127/ for more details.

Rebase

Build is green

Patch application report for D4382 (id=15504)

Rebasing onto 74544839...

Current branch diff-target is up to date.

Changes applied before test

commit 12fa6f263d48fdd200601057c0f724a60b771965
Author: tenma <tenma+swh@mailbox.org>
Date:   Thu Oct 29 14:43:52 2020 +0100

    core tests: disambiguate arg 'request' through typing
    
    Both requests.Request and _pytest.FixtureRequest objects are passed to
    test fixtures as argument 'request'. This hurts readability.
    Adding typing annotations makes it clear which one is meant.

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/128/ for more details.

Merge request was merged

closed