Skip to content

SortedList: Don't inherit from UserList.

vlorentz requested to merge generated-differential-D4087-source into generated-differential-D4087-target

A class should only inherit from UserList if the type of data it presents is the same as the data in the 'data' attribute, which isn't true here.

This means, for example, that SortedList.contains checked if the value is in self.data, which always returns False (unless unlucky, but then it returns True while it shouldn't).

By removing this inheritance, methods that are no longer implemented no longer default to a buggy implementation.

Migrated from D4087 (view on Phabricator)

Merge request reports