Skip to content
Snippets Groups Projects

Detect missing db/cur arguments in 'nested' calls and raise an error.

Open vlorentz requested to merge generated-differential-D2846-source into master

We often forget these (eg. swh-storage!359 (closed)); this diff should prevent most mistakes in the future.

On the other hand, it's not fool-proof and is a terrible hack...


Migrated from D2846 (view on Phabricator)

Merge request reports

Pipeline #5686 failed

Pipeline failed for 45110991 on generated-differential-D2846-source

Approval is optional
Merge blocked: 1 check failed
Merge request must be rebased, because a fast-forward merge is not possible.

Merge details

  • The source branch is 80 commits behind the target branch.
  • 6 commits will be added to master.
  • Source branch will not be deleted.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • This feels fragile but might do what we want. It uncovers quite some issues in swh-vault though.

  • added 1 commit

    • 6032fc3d - Checking if the cursor is closed helps with false positive

    Compare with previous version

  • Jenkins job DCORE/gitlab-builds #121 failed .
    See Console Output and Coverage Report for more details.

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading