Skip to content
Snippets Groups Projects
Renaud Boyer's avatar
Renaud Boyer's avatar
deleted branch prototype at Platform / Development / swh-coarnotify
Renaud Boyer's avatar
accepted merge request !1 "Minimal app : inbox API, models, token auth, basic payload validation" at Platform / Development / swh-coarnotify
Renaud Boyer's avatar
Renaud Boyer's avatar
commented on issue #2 "Properly handle json-ld syntax" at Platform / Development / swh-coarnotify

ok thanks, I will keep it as-is for now and keep this issue open to see when should we should schedule a proper payload parser/validator

vlorentz's avatar
commented on issue #2 "Properly handle json-ld syntax" at Platform / Development / swh-coarnotify

Indeed. That's what we do in swh-search....

Renaud Boyer's avatar
commented on issue #2 "Properly handle json-ld syntax" at Platform / Development / swh-coarnotify

Oh yeah, forgot about that, that's why you recommended json-ld expansion instead of compaction to validate / handle the payload ?

vlorentz's avatar
commented on issue #2 "Properly handle json-ld syntax" at Platform / Development / swh-coarnotify

In JSON-LD, every key not starting with a @ (including id when working with contexts that map id to @id) can be an array, an object containing at l...

Renaud Boyer's avatar
opened issue #2 "Properly handle json-ld syntax" at Platform / Development / swh-coarnotify
Renaud Boyer's avatar
commented on merge request !1 "Minimal app : inbox API, models, token auth, basic payload validation" at Platform / Development / swh-coarnotify

could you please point me to where you found this in the ldn specs ? (issue #2)

Renaud Boyer's avatar
opened issue #1 "improve json-ld errors" at Platform / Development / swh-coarnotify
Renaud Boyer's avatar
commented on merge request !1 "Minimal app : inbox API, models, token auth, basic payload validation" at Platform / Development / swh-coarnotify

ie. if an url in the @context is invalid or unreachable it will raise...

Renaud Boyer's avatar
commented on merge request !1 "Minimal app : inbox API, models, token auth, basic payload validation" at Platform / Development / swh-coarnotify

Thanks again @anlambert for your feedback on this, I will keep the auth system as-is for now but I will keep the keycloak solution in mind.

Renaud Boyer's avatar
commented on merge request !1 "Minimal app : inbox API, models, token auth, basic payload validation" at Platform / Development / swh-coarnotify

Yes, I wanted to do that in another mr but I wrote a simple structural validator to the payload

Renaud Boyer's avatar
commented on merge request !1 "Minimal app : inbox API, models, token auth, basic payload validation" at Platform / Development / swh-coarnotify

You're right, I wrote a validator that matches the specs

Jenkins Bot's avatar
commented on merge request !1 "Minimal app : inbox API, models, token auth, basic payload validation" at Platform / Development / swh-coarnotify

Jenkins job swh-coarnotify/gitlab-builds #25 succeeded in 46 sec.See Console Output, Blue Ocean and Coverage Report for more details.

Renaud Boyer's avatar
pushed to branch prototype at Platform / Development / swh-coarnotify
Jenkins Bot's avatar
commented on merge request !1 "Minimal app : inbox API, models, token auth, basic payload validation" at Platform / Development / swh-coarnotify

Jenkins job swh-coarnotify/gitlab-builds #23 succeeded in 44 sec.See Console Output, Blue Ocean and Coverage Report for more details.

Renaud Boyer's avatar
pushed to branch prototype at Platform / Development / swh-coarnotify
Jenkins Bot's avatar
commented on merge request !1 "Minimal app : inbox API, models, token auth, basic payload validation" at Platform / Development / swh-coarnotify

Jenkins job swh-coarnotify/gitlab-builds #22 failed in 44 sec.See Console Output, Blue Ocean and Coverage Report for more details.